[s3boto] custom domain hardcodes http or https

adamnelson created an issue 2011-04-13

    if self.custom_domain:
        return "%s://%s/%s" % ('https' if self.secure_urls else 'http', self.custom_domain, name)

Comments (8)

1. adamnelson

   Since AWS_CUSTOM_DOMAIN hasn't been released yet, I decided to make a backwards incompatible change such that AWS_CUSTOM_DOMAIN must include the scheme.

   If AWS_CUSTOM_DOMAIN used to be 'xyz.cloudfront.com' it should now be 'xyz.cloudfront.com' or 'http://xyz.cloudfront.com'

   I'm open to renaming the variable to be more clear or having a second variable if anybody has an opinion.

   https://github.com/Yipit/django-storages/commit/515b3affcc9dca75847cb8de63989d2b0bdf103f

   • 2011-04-26T15:16:51+00:00
2. Ian Lewis

   • assigned issue to Ian Lewis

   • 2011-09-16T06:53:14+00:00
3. Ian Lewis

   That might be a valid solution. Certainly in that case secure_urls wouldn't be needed. I'll have to think about it a bit more.

   I'd really like to limit the number of new variables. There are already like 4 variables that affect url generation.

   As a side note I usually see links without the protocol starting with ''. i.e. 'xyz.cloudfront.com' rather than simply just the domain. Otherwise the browser might get confused and think it's a file relative to the current file. Not sure the best-practice here so I'm someone is more informed than me, please let me know.

   • 2011-10-08T15:54:53+00:00
4. adamnelson

   One problem is src attributes in emails. If you use src="example.com/image.jpg" in an img tag, it will crash many versions of Outlook. Not all urls generated by django-storages end up in web browsers :-/

   • 2011-10-09T17:09:10+00:00
5. Ian Lewis

   Cute.

   • 2011-10-10T15:54:53+00:00
6. spulec

   Any update on this?

   • 2012-02-07T15:54:37+00:00
7. David Larlet

   Hello,

   See issue #107 and pull-request 42

   Thanks, David

   • 2012-12-05T09:50:40+00:00
8. David Larlet

   • changed status to duplicate

   Duplicate of #107.

   • 2012-12-05T09:50:51+00:00
9. Log in to comment »