Error uploading files with the same name.

aaquirogal created an issue 2011-12-30

Comments (3)

1. Ian Lewis

   • changed status to resolved
   • assigned issue to Ian Lewis

   There is a parameter called AWS_S3_FILE_OVERWRITE which defaults to True. This parameter controls whether the s3boto backend will overwrite files or not when they have the same name. You can set this setting to False in your settings.py to enable file name checking.

   However,

   Checking for the same name of a file means that the backend has to make extra requests to s3 to check if the file exists or not which creates overhead. It also creates concurrency problems since a file could be written between the time that the backend checks that it exists and when it actually writes it.

   For these reasons it's recommended that you use a file naming scheme that generates unique file names for all uploaded files rather than writing to a unique file name after checking if it exists.

   • 2012-01-01T08:48:03+00:00
2. aaquirogal

   Ok.. thanks...

   Then, I have created a function to add the datetime to the filename...

   I want to share it..

   import datetime
   
   def fileholder(instance,filename):
       now_str = str(datetime.datetime.now())
       now = now_str.replace(' ','-')
       print now
       ext = "xxx"
       try :
           title_str = filename.split(".")[-0]
           title = title_str.replace(' ', '-')
           ext = filename.split(".")[-1]
       except:
           pass
       return '/'.join(["uploads/images/image",title+now+"."+ext])
   

   and on my model ...

   from django.db import models
   from utils import fileholder
   
   
   class Image(models.Model):
       """
       Representa una imagen
       """
       title = models.CharField(
           max_length=200,
       )
   
       image = models.ImageField(
           max_length=100,
           upload_to= fileholder,
       )
   
       content_file = models.FileField(
           upload_to=fileholder,
           blank=True,
           null=True,
       )
   

   Thanks... :o)

   • 2012-01-02T13:56:01+00:00
3. Can you please updated your documentation to include this rather important setting?

   Thanks.

   • 2012-03-23T17:50:00+00:00
4. Log in to comment »