Assignee
David Larlet
Type
bug
Priority
major
Status
resolved
Watchers
2

Minor issue in test - not recalculating the signature when changing the nonce

mohangk avatarmohangk created an issue

There is a minor bug in the test line below

http://bitbucket.org/david/django-oauth/src/tip/oauth_provider/tests.py#cl-475

Although the nonce is changed, the old signature is reused. In this particular case because what is being tested is the revocation of the access_token and that is still fine, however in the case the access_token is not revoked, the tests still (wrongly) returns a 401, however for the signature being wrong instead. This might lead to confusion.

Comments (3)

  4. Log in to comment »
Tip: Filter by directory path e.g. /media app.js to search for public/media/app.js.
Tip: Use camelCasing e.g. ProjME to search for ProjectModifiedEvent.java.
Tip: Filter by extension type e.g. /repo .js to search for all .js files in the /repo directory.
Tip: Separate your search with spaces e.g. /ssh pom.xml to search for src/ssh/pom.xml.
Tip: Use ↑ and ↓ arrow keys to navigate and return to view the file.
Tip: You can also navigate files with Ctrl+j (next) and Ctrl+k (previous) and view the file with Ctrl+o.
Tip: You can also navigate files with Alt+j (next) and Alt+k (previous) and view the file with Alt+o.